Fix error when activity is provided #86
Merged
+35
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #86 +/- ##
=======================================
Coverage 88.34% 88.34%
=======================================
Files 54 54
Lines 2857 2857
=======================================
Hits 2524 2524
Misses 333 333 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tr4nt0r
requested changes
Jan 22, 2026
Owner
tr4nt0r
left a comment
tr4nt0r
left a comment
There was a problem hiding this comment.
Nice, thank you. But could you please also update the tests? I think it should be enough to replace presence.json with one of your examples that you have captured
⬆️ Bump release-drafter/release-drafter digest to 6db134d (tr4nt0r#87)
Contributor
Author
|
I added a new test and verified it passes with this PR and fails without it |
Owner
|
can you put the test data in a JSON fixture in |
Contributor
Author
|
I'll figure it out |
Contributor
Author
|
I made the requested change. It passes all my checks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When activity is returned, it is causing an error because it is a dict not a list.
This fixes: #85